fix(docs): Iceberg connector reference in ANALYZE docs #27041
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ishaan-2312
requested review from
a team,
elharo and
steveburnett
as code owners
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the ANALYZE SQL documentation to reference the correct Iceberg connector, fixing an outdated or incorrect connector name in the docs. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `presto-docs/src/main/sphinx/sql/analyze.rst:23-25` </location>
<code_context>
Currently, this statement is only supported by the
-:ref:`Hive connector <hive_analyze>`.
+:ref:`Hive connector <hive_analyze>` and
+:doc:`Iceberg connector <../connector/iceberg>`.
Examples
</code_context>
<issue_to_address>
**suggestion (typo):** Consider adding "the" before "Iceberg connector" for parallel structure.
This will keep the phrasing grammatically consistent with the existing "the Hive connector" reference.
```suggestion
Currently, this statement is only supported by the
:ref:`Hive connector <hive_analyze>` and
:doc:`the Iceberg connector <../connector/iceberg>`.
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
23
to
+25
| Currently, this statement is only supported by the | ||
| :ref:`Hive connector <hive_analyze>`. | ||
| :ref:`Hive connector <hive_analyze>` and | ||
| :doc:`Iceberg connector <../connector/iceberg>`. |
Contributor
There was a problem hiding this comment.
suggestion (typo): Consider adding "the" before "Iceberg connector" for parallel structure.
This will keep the phrasing grammatically consistent with the existing "the Hive connector" reference.
Suggested change
| Currently, this statement is only supported by the | |
| :ref:`Hive connector <hive_analyze>`. | |
| :ref:`Hive connector <hive_analyze>` and | |
| :doc:`Iceberg connector <../connector/iceberg>`. | |
| Currently, this statement is only supported by the | |
| :ref:`Hive connector <hive_analyze>` and | |
| :doc:`the Iceberg connector <../connector/iceberg>`. |
tdcmeehan
changed the title
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
Consider adding an example to the Iceberg connector doc that parallels the linked doc in the Hive connector.
Contributor
|
Please edit the PR Description to set the release note as (including the row of three (`) above and below the text to format it as code) to pass the (not required to merge) failing test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Earlier the Iceberg connector did not get linked to a valid page and now it is fixed and mapped to the link of Iceberg connector page
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: